fix: Stop RM errors when using acceleratedDHT#9407
Merged
ajnavarro merged 4 commits intorelease-v0.17.0from Nov 15, 2022
Merged
fix: Stop RM errors when using acceleratedDHT#9407ajnavarro merged 4 commits intorelease-v0.17.0from
ajnavarro merged 4 commits intorelease-v0.17.0from
Conversation
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
This was referenced Nov 15, 2022
BigLep
reviewed
Nov 15, 2022
Contributor
BigLep
left a comment
There was a problem hiding this comment.
@ajnavarro : thinking on this more, I think we should just remove the connection with between the resource manager and "cfg.ConnMgr.HighWater". Lets let them operate independently. I made a commit with my suggested code change.
Can you then confirm that this works with both the scenarios that @lidel mentioned in #9405 and #9406 ?
Thanks
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
c6e3d54 to
14fbf0b
Compare
Member
Author
|
@BigLep confirmed that it works with both ConnMgr configurations. |
Co-authored-by: Steve Loeppky <biglep@protocol.ai>
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It closes #9405
Signed-off-by: Antonio Navarro Perez antnavper@gmail.com