Skip to content

feat: Delegated routing with custom configuration.#9274

Merged
ajnavarro merged 19 commits intomasterfrom
feature/delegated-routing-v2
Sep 22, 2022
Merged

feat: Delegated routing with custom configuration.#9274
ajnavarro merged 19 commits intomasterfrom
feature/delegated-routing-v2

Conversation

@ajnavarro
Copy link
Copy Markdown
Member

@ajnavarro ajnavarro commented Sep 13, 2022

New multi-router configuration system based on https://hackmd.io/G1KRDEX5T3qyfoBMkIrBew#Methods

  • Added a new routing type: "custom"
  • Added specific struct types for different Routers (instead of map[string]interface{})
  • Added Duration config type, to make easier time string parsing
  • Added config documentation.
  • Use the latest go-delegated-routing library version with GET support.
  • Added changelog notes for this feature.

It:

@ajnavarro ajnavarro requested a review from guseggert September 13, 2022 13:35
@ajnavarro ajnavarro modified the milestone: Best Effort Track Sep 13, 2022
@ajnavarro ajnavarro self-assigned this Sep 13, 2022
@ajnavarro ajnavarro force-pushed the feature/delegated-routing-v2 branch from e408da1 to c0d9101 Compare September 16, 2022 10:56
@ajnavarro ajnavarro marked this pull request as ready for review September 16, 2022 20:49
@ajnavarro ajnavarro force-pushed the feature/delegated-routing-v2 branch from a1ea310 to 7573b72 Compare September 16, 2022 21:42
@ajnavarro ajnavarro force-pushed the feature/delegated-routing-v2 branch 3 times, most recently from 5113650 to 0c32e28 Compare September 19, 2022 09:59
@galargh galargh mentioned this pull request Sep 19, 2022
@ajnavarro ajnavarro force-pushed the feature/delegated-routing-v2 branch 2 times, most recently from 6491bc5 to d59a23c Compare September 21, 2022 12:13
@ajnavarro ajnavarro force-pushed the feature/delegated-routing-v2 branch 2 times, most recently from 79961eb to 98a7acf Compare September 21, 2022 19:11
@ajnavarro ajnavarro requested a review from guseggert September 21, 2022 19:14
@BigLep
Copy link
Copy Markdown
Contributor

BigLep commented Sep 22, 2022

@ajnavarro : I don't think we should say "closes #9150" since that issue is done when reframe is used in Kubo in production. This PR is an important step but not the end.

@ajnavarro
Copy link
Copy Markdown
Member Author

@BigLep removed that issue from the list.

Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
@ajnavarro ajnavarro force-pushed the feature/delegated-routing-v2 branch from 36a8454 to 6fbe75d Compare September 22, 2022 09:29
@ajnavarro ajnavarro force-pushed the feature/delegated-routing-v2 branch 2 times, most recently from 1f890c9 to 5307ed1 Compare September 22, 2022 11:30
@ajnavarro ajnavarro force-pushed the feature/delegated-routing-v2 branch from 5307ed1 to a067db5 Compare September 22, 2022 11:37
@ajnavarro ajnavarro merged commit d1b9e41 into master Sep 22, 2022
@ajnavarro ajnavarro deleted the feature/delegated-routing-v2 branch September 22, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

Expose/use reframe.provide Delegated Routing: Allow to configure methods used by router. Routing: conform DHT to common Router interface

3 participants