chore(gw): extract logical functions to improve readability#8885
Merged
Jorropo merged 3 commits intoipfs:masterfrom Apr 15, 2022
justindotpub:justincjohnson/refactor-gateway
Merged
chore(gw): extract logical functions to improve readability#8885Jorropo merged 3 commits intoipfs:masterfrom justindotpub:justincjohnson/refactor-gateway
Jorropo merged 3 commits intoipfs:masterfrom
justindotpub:justincjohnson/refactor-gateway
Conversation
…epare for later refactorings
3 tasks
Jorropo
requested changes
Apr 15, 2022
Contributor
Jorropo
left a comment
There was a problem hiding this comment.
This is definitely clearer. thx 🙂
Just a few final things.
Jorropo
reviewed
Apr 15, 2022
Contributor
Author
|
I believe I've addressed everything @Jorropo. Let me know if I missed anything, and thanks again for the feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another take at #8883 from my personal account this time.