fix dag test fixtures for go-ipld-prime codecs#8257
Merged
rvagg merged 4 commits intofeat/dag-put-ipld-primefrom Jul 21, 2021
Merged
fix dag test fixtures for go-ipld-prime codecs#8257rvagg merged 4 commits intofeat/dag-put-ipld-primefrom
rvagg merged 4 commits intofeat/dag-put-ipld-primefrom
Conversation
rvagg
commented
Jul 15, 2021
willscott
approved these changes
Jul 15, 2021
Contributor
willscott
left a comment
There was a problem hiding this comment.
thanks for digging through these!
5961cd1 to
9f5af56
Compare
Member
Author
|
Now using go-ipld-prime master with DAG-JSON sorting and no whitespace. Still having trouble with the full sharness run in Circle but will merge this into the feat/dag-put-ipld-prime when CI is done if it doesn't throw up anything new. The sharness problems can be worked on in that branch. |
48 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pending ipld/go-ipld-prime#202 and ipld/go-ipld-prime#203
dag getdoesn't print a newline now, which I think is the right behaviour since it can now do any codec and newlines are going to be a problem for the stricter binary formats than dag-json, so I've adapted the fixtures.Data/Linkschanges show up here and are now correct, as are the new (proper) rules for showing bytes with DAG-JSON.dag stat, this comes from go-ipld-cbor doing always-64-bit integers, but we're now doing always-smallest-possible now across all our codecs, so go-ipld-cbor is the odd one out (old and new JS codecs do this, and spec says it).