Conversation
dirkmc
approved these changes
Apr 28, 2020
Co-Authored-By: Peter Rabbitson <ribasushi@protocol.ai>
Stebalien
commented
Apr 28, 2020
jacobheun
reviewed
Apr 28, 2020
momack2
reviewed
Apr 28, 2020
Contributor
momack2
left a comment
There was a problem hiding this comment.
I got to libp2p - shipping suggestions now
CHANGELOG.md
Outdated
| be logarithmic in the size of the network to be linear. | ||
| - Most peers in the DHT cannot be dialed (e.g., due to firewalls and NATs). Much of a DHT query time is wasted trying to connect to peers that cannot be reached. | ||
| - The DHT query logic doesn't properly terminate when it hits the end of the query and, instead, aggressively keeps on searching. | ||
| - The routing tables are poorly maintained. This can cause a search that should be logarithmic in the size of the network to be linear. |
Contributor
There was a problem hiding this comment.
Suggested change
| - The routing tables are poorly maintained. This can cause a search that should be logarithmic in the size of the network to be linear. | |
| - The routing tables were poorly maintained, which could cause a search that _should_ be logarithmic in the size of the network to instead be linear. |
CHANGELOG.md
Outdated
| be logarithmic in the size of the network to be linear. | ||
| - Most peers in the DHT cannot be dialed (e.g., due to firewalls and NATs). Much of a DHT query time is wasted trying to connect to peers that cannot be reached. | ||
| - The DHT query logic doesn't properly terminate when it hits the end of the query and, instead, aggressively keeps on searching. | ||
| - The routing tables are poorly maintained. This can cause a search that should be logarithmic in the size of the network to be linear. | ||
|
|
||
| ###### Reachable |
Contributor
There was a problem hiding this comment.
Suggested change
| ###### Reachable | |
| ###### Reachability |
CHANGELOG.md
Outdated
|
|
||
| What this means for users: | ||
| Continuing on with the of improving our core data handling subsystems, both of the datastores used in go-ipfs, badger and flatfs, have received important updates in this release: |
Contributor
There was a problem hiding this comment.
Suggested change
| Continuing on with the of improving our core data handling subsystems, both of the datastores used in go-ipfs, badger and flatfs, have received important updates in this release: | |
| Continuing on with the theme of improving our core data handling subsystems, both of the datastores used in go-ipfs, badger and flatfs, have received important updates in this release: |
…twork upgrading to the Changelog
momack2
reviewed
Apr 28, 2020
momack2
reviewed
Apr 28, 2020
mburns
reviewed
Apr 28, 2020
mburns
reviewed
Apr 28, 2020
Co-Authored-By: MollyM <momack2@users.noreply.github.com> Co-Authored-By: Jacob Heun <jacobheun@gmail.com>
momack2
reviewed
Apr 28, 2020
momack2
reviewed
Apr 28, 2020
Co-Authored-By: Jacob Heun <jacobheun@gmail.com> Co-Authored-By: MollyM <momack2@users.noreply.github.com> Co-Authored-By: Michael Burns <5170+mburns@users.noreply.github.com>
momack2
reviewed
Apr 28, 2020
CHANGELOG.md
Outdated
|
|
||
| #### Badger Datastore | ||
| 1. Pubsub now more aggressively finds and connects to other peers peers subscribing to the same topic. |
Contributor
There was a problem hiding this comment.
Suggested change
| 1. Pubsub now more aggressively finds and connects to other peers peers subscribing to the same topic. | |
| 1. Pubsub now more aggressively finds and connects to other peers subscribing to the same topic. |
Co-Authored-By: MollyM <momack2@users.noreply.github.com>
jacobheun
reviewed
Apr 28, 2020
momack2
reviewed
Apr 28, 2020
CHANGELOG.md
Outdated
|
|
||
| #### Badger Datastore | ||
| 1. Pubsub now more aggressively finds and connects to other peers peers subscribing to the same topic. | ||
| 2. Go-ipfs has switched its the default pubsub router from "floodsub", an inefficient but simple "flooding" pubsub implementation, to "gossipsub". |
Contributor
There was a problem hiding this comment.
Suggested change
| 2. Go-ipfs has switched its the default pubsub router from "floodsub", an inefficient but simple "flooding" pubsub implementation, to "gossipsub". | |
| 2. Go-ipfs has switched the default pubsub router from "floodsub", an inefficient but simple "flooding" pubsub implementation, to "gossipsub". |
Co-Authored-By: Jacob Heun <jacobheun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #6776