Closed
Conversation
ad030d7 to
8d9728f
Compare
89b752e to
face434
Compare
Stebalien
requested changes
Jul 9, 2019
Member
Stebalien
left a comment
There was a problem hiding this comment.
I've gone ahead and merged the config changes anyways as that likely won't change.
However, let's make sure to update the config documentation while we're at it.
Contributor
Author
|
I'm closing this as it was just an option for the recent dht push. Ultimately, provide roots will not use the old reprovider system as is the case in this PR. Thanks for taking a look. |
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires: ipfs/go-ipfs-config#38
This is a quick and straightforward change to (1) disable bitswap providing, and (2) enable providing of roots in the new providing system. This does not make the codebase better and will be factored differently in time.
The following configs are needed:
Here "roots" is defined by the root hashes created during
ipfs addandipfs pin addcommands.