Skip to content

WIP – Add reprovider; Make provider much more robust#6141

Closed
michaelavila wants to merge 25 commits intomasterfrom
features/provide-reprovide
Closed

WIP – Add reprovider; Make provider much more robust#6141
michaelavila wants to merge 25 commits intomasterfrom
features/provide-reprovide

Conversation

@michaelavila
Copy link
Contributor

@michaelavila michaelavila commented Mar 27, 2019 •
edited
Loading

Supersedes: #5870

TODO

  • reprovide cids that have been provided and still exist in the blockstore
  • provide root block at every necessary point
    • list out all locations here
  • provide using strategy only at necessary points
    • list out all locations here
  • migrations from old reprovide strategies to new provide system
  • document how to troubleshoot provider system

Stretch TODO

  • config to disable providing
    • I think this can be accomplished through a "none" strategy
  • ipfs provider tracking to list the cids the provider system is tracking

@michaelavila michaelavila requested a review from Kubuxu as a code owner March 27, 2019 15:34
@ghost ghost assigned michaelavila Mar 27, 2019
@ghost ghost added the status/in-progress In progress label Mar 27, 2019
@michaelavila michaelavila force-pushed the features/provide-reprovide branch from c16edb6 to b4d7a71 Compare March 27, 2019 16:29
@michaelavila michaelavila mentioned this pull request Mar 27, 2019
Closed
8 tasks
@michaelavila michaelavila force-pushed the features/provide-reprovide branch 7 times, most recently from 14e9d71 to c3b19d7 Compare March 27, 2019 23:35
This was referenced Apr 1, 2019
Closed
Open
@michaelavila michaelavila force-pushed the features/provide-reprovide branch 9 times, most recently from abf778e to a8e45f1 Compare April 3, 2019 20:39
@michaelavila
Add tracker and tests
cfe8185 
License: MIT
Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
@michaelavila
Add reprovider + reprovider tests
e4022be 
License: MIT
Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
@michaelavila
Add logic for untracking cids that are no longer in the blockstore
5d43afa 
License: MIT
Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
@michaelavila
Skip providing blocks that have already been provided
28de6a5 
License: MIT
Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
@michaelavila
Fix go fmt and related issues
0301e6d 
License: MIT
Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
@michaelavila
Fix builder to construct NewProvider
6760333 
License: MIT
Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
@michaelavila
Add reprovider
737508c 
License: MIT
Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
@michaelavila
Modify to always track when providing; Add tests
7542467 
License: MIT
Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
@michaelavila
Remove unnecessary return type from Provide
192c2cc 
License: MIT
Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
@michaelavila
Remove old reprovider
8b39934 
License: MIT
Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
@michaelavila
Restore old iptb-lib functions
01de878 
License: MIT
Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
@michaelavila
Remove unused peer_id lib sharness function
002a1e0 
License: MIT
Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
@michaelavila
Cleanup
3008266 
License: MIT
Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
@michaelavila
Add ipfs provider tracking
3e70f05 
License: MIT
Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
@michaelavila
Move reprovide subcmd to provider cmd
771f4d5 
License: MIT
Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
@michaelavila
Fix style issues
d707da9 
License: MIT
Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
@michaelavila
Add new commands to commands_test
7c806da 
License: MIT
Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
@michaelavila
Remove leftover files from rebase
e05caf5 
License: MIT
Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
@michaelavila
Return whatever queue returns on Close()
b9299b4 
License: MIT
Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
@michaelavila
Move Provider behind ProviderSystem
46296c4 
License: MIT
Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
@michaelavila
Add Close() to reprovider
92a9d0a 
License: MIT
Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
@michaelavila
Move reprovider behind ProviderSystem
0bf621c 
License: MIT
Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
@michaelavila michaelavila force-pushed the features/provide-reprovide branch from e6a39a7 to 0bf621c Compare April 12, 2019 14:56
@michaelavila
Fix style issues
f8c8d85 
License: MIT
Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
@michaelavila
Rename ProviderSystem to System
2d1a4c2 
License: MIT
Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
@michaelavila michaelavila force-pushed the features/provide-reprovide branch from 6c78140 to 2d1a4c2 Compare April 12, 2019 15:45
@michaelavila
Rename Trigger to Reprovide
3698d3e 
License: MIT
Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
@michaelavila michaelavila mentioned this pull request Apr 15, 2019
Open
@michaelavila
Copy link
Contributor Author

michaelavila commented May 14, 2019

This work is being superseded by upcoming PRs (including: #6292).

@michaelavila michaelavila mentioned this pull request Jul 30, 2019
Open
22 tasks
@hacdias hacdias deleted the features/provide-reprovide branch May 9, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

Assignees

@michaelavila michaelavila

Labels

status/in-progress In progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michaelavila @momack2