Provide root node immediately on add and pin add#6068
Merged
Conversation
License: MIT Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
9301556 to
a9b6534
Compare
This is being removed because it appears that the provide announcements go out regardless of the timeout. License: MIT Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
License: MIT Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
fdcf655 to
dafc9de
Compare
License: MIT Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
dafc9de to
dde397e
Compare
added 2 commits
March 14, 2019 16:54
License: MIT Signed-off-by: Erik Ingenito <erik@carbonfive.com>
License: MIT Signed-off-by: Erik Ingenito <erik@carbonfive.com>
a36a278 to
6cefbb6
Compare
License: MIT Signed-off-by: Erik Ingenito <erik@carbonfive.com>
6cefbb6 to
5d4f3fb
Compare
added 2 commits
March 15, 2019 14:19
License: MIT Signed-off-by: Erik Ingenito <erik@carbonfive.com>
25474eb to
7fcafb6
Compare
License: MIT Signed-off-by: Erik Ingenito <erik@carbonfive.com>
55f02ea to
2454dd3
Compare
2454dd3 to
47fb37f
Compare
added 2 commits
March 16, 2019 09:53
License: MIT Signed-off-by: Erik Ingenito <erik@carbonfive.com>
License: MIT Signed-off-by: Erik Ingenito <erik@carbonfive.com>
47fb37f to
09cc62e
Compare
Stebalien
requested changes
Mar 18, 2019
Member
Stebalien
left a comment
There was a problem hiding this comment.
My only real comment is on querying the datastore. Otherwise, LGTM!
Thanks!
Member
|
@michaelavila let's add some docs and then we can merge this and fix the dht query stuff later. |
13e417e to
f1461d2
Compare
Contributor
Author
|
@Stebalien I believe all feedback was correctly accounted for. Please advise if not. |
f1461d2 to
e4badd3
Compare
Stebalien
requested changes
Mar 20, 2019
License: MIT Signed-off-by: Michael Avila <davidmichaelavila@gmail.com>
Contributor
Author
|
@Stebalien Ok, thanks for looking. Updated as suggested. One note: my conditional is the opposite of yours, but I think yours was just a typo. |
e4badd3 to
019af75
Compare
Stebalien
approved these changes
Mar 20, 2019
Member
Stebalien
left a comment
There was a problem hiding this comment.
Yes, my conditional was just a typo. Let's ship this!
Member
|
🎉 |
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide root node immediately when
ipfs add <cid>andipfs pin add <cid>.This PR introduces part of the new provider subsystem from the rest of the ongoing provider work so it's more extensive than it might otherwise have been. This seemed like a good way to merge some of that work and begin using it. And he work to get this PR mergeable will get folded back into #5870
Addresses: #6067