Introducing EncodedFSKeystore with base32 encoding#6012
Introducing EncodedFSKeystore with base32 encoding#6012AuHau wants to merge 1 commit intoipfs:masterfrom
Conversation
1216752 to
e96bbcc
Compare
|
The failing test does not seem to be related to this PR. Btw. I started to really like this feature, because it will enable to namespace the key's names like: |
|
Agree with after release, also I would wait with merging/migration until we can collect everything we might what to migrate. |
e96bbcc to
12c0ef9
Compare
|
Fixed conflict. Also one question, I have used |
|
For consistency, it might be better to just use base32. Using multibase doesn't buy us anything in this case. |
Encoding the key's filename with base32 introduces coherent behaviour across different platforms and their case-sensitive/case-insensitive file-systems. Moreover it allows wider character set to be used for the name of the keys as the original restriction for special FS's characters (e.g. '/', '.') will not apply. License: MIT Signed-off-by: Adam Uhlir <uhlir.a@gmail.com>
12c0ef9 to
a6b4745
Compare
|
The only blocker is migrations at this point. |
|
Migration is almost ready at: ipfs/fs-repo-migrations#84 |
|
We will have other things in the migration: ipfs/fs-repo-migrations#85 |
Encoding the key's filename with base32 introduces coherent behavior
across different platforms and their case-sensitive/case-insensitive
file-systems. Moreover, it allows a wider character set to be used for the
name of the keys as the original restriction for special FS's characters
(e.g. '/', '.') will not apply.
Tightly coupled with migration: ipfs/fs-repo-migrations#84