coreapi: replace coreiface.DagAPI with ipld.DAGService#5922
Merged
Conversation
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
51 tasks
schomatis
approved these changes
Jan 14, 2019
Contributor
schomatis
left a comment
There was a problem hiding this comment.
I don't have enough knowledge of the CoreAPI but this feels more natural to me.
Stebalien
approved these changes
Jan 21, 2019
Member
Stebalien
left a comment
There was a problem hiding this comment.
I agree that this is the right direction. I'm going to merge this now as the interface in go-ipfs is unstable but we need to make sure that ipfs-interface-core matches.
Member
Author
Conceptually using go-ipld-format.DAGService is going to be closer to js/ipfs-interface-core, only the names are a bit different - |
Member
|
SGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As
api.Dag()is the interface to IPLD, this feels like the right thing to do.This wasn't done this way before because we keep format parsers in a global map in
core/coredag, exposing ipld interfaces directly would make it tricky for outside code to do things like parse json to dag-cbor, but from my experience most Go code which touches IPLD doesn't really need those parsers.(Since this is mostly a yes/no decision, I'd like this to move relatively fast as it's blocking a chunk of work in go-ipfs-http-api)