Conversation
97ffa39 to
988fb7a
Compare
Member
Author
|
Blocked by a bug in go-path |
cdf58f1 to
e22dd35
Compare
b7b84ce to
301fcf8
Compare
Kubuxu
reviewed
Aug 14, 2018
| }) | ||
| rp, err := api.ResolvePath(req.Context, p) | ||
| if err != nil { | ||
| res.SetError(err, cmdkit.ErrNormal) |
Member
There was a problem hiding this comment.
Should we emit error here too?
What do you think?
Member
There was a problem hiding this comment.
Reading original code we probably shouldn't unless ResolvePath does a lot more than just Decode.
Member
Author
There was a problem hiding this comment.
It does handle ipns and path traversal too
Kubuxu
reviewed
Aug 14, 2018
core/coreapi/block.go
Outdated
| settings.Codec = "v0" | ||
| } | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Should this be in BlockPutOptions instead, it seems like it is options handling.
Member
There was a problem hiding this comment.
This way we separate Options sanitation from implementation.
a2955d0 to
dc5d66c
Compare
dc5d66c to
cccd98c
Compare
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
cccd98c to
1f98f4b
Compare
Stebalien
approved these changes
Aug 27, 2018
Member
Stebalien
left a comment
There was a problem hiding this comment.
LGTM for now. However, the interface will likely change when we start addressing blocks by hash instead of by CID.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.