Conversation
| defer listener.Close() | ||
|
|
||
| for { | ||
| remote, err := listener.Accept() |
There was a problem hiding this comment.
I haven't found a way to get peer address. Should we left determining peer identity up to applications using this interface or is there actually a way to get peer ID?
There was a problem hiding this comment.
the object returned here should be a stream that you can call ID() on (or .Conn().ID())
|
Alright, i think this would be really fun to have merged in. Heres what I see us possibly doing: We add a config field value or daemon flag for |
|
The tests are failing because you have the wrong gx import paths, you can use |
|
@whyrusleeping they are now failing because of that as HEAD changed dep. |
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
7ff2192 to
2c68b76
Compare
|
I'm pretty happy with this. Will need to run the idea by @jbenet, but this is a pretty cool thing to have (even if its just an experiment) |
|
Error from teamcity: |
|
Circle is having different errors, something about wrong usage of netcat. |
|
This is a cool idea, lemme review the interface when I'm back on land. Btw finding a solid way to do this for libp2p would be ideal, and go-ipfs Btw, @magik6k check out the plans over at https://github.com/ipfs/xtp --
|
License: MIT Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
|
I'll take a look at these test failures when i get a chance. I want to try and get this in (at least as an experimental feature) |
|
I think we should have the ability for a dial out to setup a local listening port, so client software can connect to it like it would a remote service. The current method requires apps to be listening on both sides, no matter whether it's a listen or a dial call. Attached my patch |
|
Closing as #3943 got merged |
This implements ipfs/notes#160 and obsoletes #2765
I've tested it manually using two nodes and the connection worked.