feat(client/rpc): auto-generate RPC GO client#11210
Draft
Conversation
…finitions add a code generator that walks the kubo command tree and produces typed Go methods on `*HttpApi` for every HTTP-accessible command. adding a new kubo command now requires zero manual client work. - tools/gen-rpc-client/: generator tool (walk, reflect, generate, templates, smoke) - client/rpc/gen_*.go: 145 generated methods across 35 files - client/rpc/gen_smoke_test.go: generated smoke tests (93 exercised, 52 skipped) - core/commands/cmdutils/: ResponseKind annotation for streaming commands - core/commands/*.go: annotate ~20 streaming commands with ResponseKind - client/rpc/*.go: deprecation comments on old CoreAPI adapter types - Rules.mk: `make rpc_client` and `make rpc_client_check` targets - .github/workflows/golang-analysis.yml: CI check for stale generated code - docs/changelogs/v0.41.md: changelog entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
not ready yet, early exploration of alternative to manually maintained
client/rpc, as noted in #11069 (comment)add a code generator that walks the kubo command tree and produces typed Go methods on
*HttpApifor every HTTP-accessible command. adding a new kubo command now requires zero manual client work.ResponseKindCoreAPIadapter typesmake rpc_clientandmake rpc_client_checktargets