Conversation
Upgrade go-ds-flatfs to version that uses uses temproary files to store items added to batches. See: ipfs/go-ds-flatfs#142
documents the new flatfs batch implementation that uses atomic operations via temp directory, preventing orphan blocks on interrupted imports and reducing memory usage.
e9337bb to
4c80584
Compare
lidel
requested changes
Dec 9, 2025
Member
There was a problem hiding this comment.
looks fine on linux, did some end-to-end tests without issues but I don't think we tested macOS and windows (which could have different behaviors)?
i think we can merge as long we cover testing on windows somehow:
- address the duplicate key thing in ipfs/go-ds-flatfs#142 (review)
- test
ipfs addwith this PR on Windows- see concern in ipfs/go-ds-flatfs#142 (review)
- test
ipfs addwith this PR on - switch this branch to new release of flatfs before merging
go.mod
Outdated
| github.com/ipfs/go-detect-race v0.0.1 | ||
| github.com/ipfs/go-ds-badger v0.3.4 | ||
| github.com/ipfs/go-ds-flatfs v0.5.5 | ||
| github.com/ipfs/go-ds-flatfs v0.5.6-0.20251114193714-784ae9fcab46 |
Member
There was a problem hiding this comment.
- release v0.6.0 and switch to that?
Contributor
|
Triage:
|
# Conflicts: # docs/changelogs/v0.40.md
includes improved tests, batch cleanup fixes, and docs
focus on user benefits instead of implementation details
lidel
approved these changes
Jan 13, 2026
Member
lidel
left a comment
There was a problem hiding this comment.
Updated to latest commit from ipfs/go-ds-flatfs#142 and seems ok.
@gammazero feel free to merge that PR and then switch this to commit from master there and merge this too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade go-ds-flatfs to version that uses uses temproary files to store items added to batches.