fix(gateway): prevent blocked CIDs in CAR responses#10948
Draft
fix(gateway): prevent blocked CIDs in CAR responses#10948
Conversation
This was referenced Aug 30, 2025
Closed
Updates boxo to include the fix for blocked CIDs appearing in CAR responses and enables the previously commented test cases. Uses boxo PR #1019 which ensures content filtering policies are enforced for CAR format responses by properly separating DAGService usage during traversal. Ref: ipfs/boxo#1019 Closes #10361
431116c to
fea028b
Compare
- test HTTP 200 with CAR for safe subdirectory when sibling is blocked - test HTTP 404 for non-existent paths with CAR format - test HTTP 410 for blocked root CID with CAR format - verify safe content is included and blocked content is excluded from CARs - distinguish between blocked (410) and not found (404) responses These tests document the expected behavior when content blocking interacts with CAR format responses, ensuring proper HTTP status codes and content filtering.
- nopfs: SessionExchange support and optimized blocking checks ipfs-shipyard/nopfs#50 - boxo: restored session usage in CAR streaming with proper blocking ipfs/boxo#1019 fixes #10361
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
This wip experimentation to see gateway-conformance regressions, not ready for review yet.
Uses boxo PR #1019 which ensures content filtering policies are enforced for CAR format responses and also improved handling of returning 404s instead of 200s if we know the path is invalid of gateway does not have root (
Gateway.NoFetch).?format=cardoes not skip directly blocked CIDs #10361