Skip to content

refactor: namesys cleanup, gateway /ipns/ ttl#10115

Merged
hacdias merged 6 commits intomasterfrom
ns-cleanup
Oct 18, 2023
Merged

refactor: namesys cleanup, gateway /ipns/ ttl#10115
hacdias merged 6 commits intomasterfrom
ns-cleanup

Conversation

@hacdias
Copy link
Copy Markdown
Member

@hacdias hacdias commented Sep 5, 2023 •
edited
Loading

@hacdias hacdias added the skip/changelog This change does NOT require a changelog entry label Sep 5, 2023
@hacdias hacdias self-assigned this Sep 5, 2023
@hacdias hacdias mentioned this pull request Sep 5, 2023
Merged
4 tasks
@hacdias hacdias changed the base branch from master to path-consolidation September 5, 2023 13:21
@hacdias hacdias force-pushed the path-consolidation branch 2 times, most recently from 6338df4 to f5b4175 Compare September 7, 2023 09:22
@hacdias hacdias force-pushed the ns-cleanup branch 2 times, most recently from 7c1a4ed to 19e5f0e Compare September 8, 2023 12:17
@hacdias hacdias force-pushed the path-consolidation branch 2 times, most recently from 77ea675 to 4b18d58 Compare September 18, 2023 08:35
@hacdias hacdias force-pushed the path-consolidation branch 3 times, most recently from f78a7ee to 21d1144 Compare September 27, 2023 11:12
@hacdias hacdias force-pushed the ns-cleanup branch 4 times, most recently from cf4c980 to 4007649 Compare October 2, 2023 09:56
@hacdias hacdias mentioned this pull request Oct 2, 2023
Merged
@hacdias hacdias marked this pull request as ready for review October 2, 2023 13:22
@hacdias hacdias requested review from a team and lidel as code owners October 2, 2023 13:22
@hacdias hacdias force-pushed the path-consolidation branch 4 times, most recently from 297c4bb to 9e7452e Compare October 6, 2023 08:30
@hacdias hacdias force-pushed the path-consolidation branch from 9e7452e to 8017256 Compare October 6, 2023 08:33
Base automatically changed from path-consolidation to master October 6, 2023 14:14
lidel
lidel approved these changes Oct 18, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed some changes from ipfs/boxo#459, mainly the changelog and wiring up the updated IPNS defaults that are now clearly defined in boxo/namesys.

@hacdias We need a basic test for gateway (detail inline), but other than that lgtm.

hacdias and others added 4 commits October 18, 2023 09:38
@hacdias
refactor: namesys cleanup, gateway /ipns/ ttl
a21babf
@lidel @hacdias
docs: ipfs name publish --help
21013eb 
Basic UX improvement that makes helptext up-to-date and more useful.
@lidel @hacdias
docs: explicit ipfs name publish --ttl
31384b1 
The TTL is not optional:
https://specs.ipfs.tech/ipns/ipns-record/#ipns-record
and it is better to clearly state what is the implicit default,
rather than hide it from user.
@lidel @hacdias
docs: changelog and --help
1c4d702
@hacdias hacdias merged commit 4695fd9 into master Oct 18, 2023
@hacdias hacdias deleted the ns-cleanup branch October 18, 2023 08:23
@hacdias hacdias mentioned this pull request Oct 18, 2023
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lidel lidel lidel approved these changes

Assignees

@hacdias hacdias

Labels

skip/changelog This change does NOT require a changelog entry

Projects

No open projects
IPFS Shipyard Team
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hacdias @lidel