Skip to content

Migration from v9 to v10 ends up with duplicate swarm-listening definitions #7444

@RubenKelevra

Description

@RubenKelevra

I tried to use the v9 to v10 migration on two nodes, in both cases there was already a QUIC listening definition in the swarm-listening array.

The migration added an identical secondary listening entry for QUIC (twice, one for IPv4 one for IPv6).

On the first node, this ended up with just a weird config, since the port is random:

    "Swarm": [
      "/ip4/0.0.0.0/tcp/0",
      "/ip6/::/tcp/0",
      "/ip4/0.0.0.0/udp/0/quic",
      "/ip6/::/udp/0/quic",
      "/ip4/0.0.0.0/udp/0/quic",
      "/ip6/::/udp/0/quic"
    ]

On the secondary node this is ending up with this duplicate entries:

    "Swarm": [
      "/ip4/0.0.0.0/tcp/443",
      "/ip6/::/tcp/443",
      "/ip4/0.0.0.0/udp/443/quic",
      "/ip6/::/udp/443/quic",
      "/ip4/0.0.0.0/udp/443/quic",
      "/ip6/::/udp/443/quic"
    ]

Proposed solution

If there's any quic definition in the listing ports, just skip this migration step.

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugA bug in existing code (including security flaws)need/triageNeeds initial labeling and prioritization

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions