fix: handle non-printable characters in browser responses#57
Closed
achingbrain wants to merge 1 commit intomasterfrom
Closed
fix: handle non-printable characters in browser responses#57achingbrain wants to merge 1 commit intomasterfrom
achingbrain wants to merge 1 commit intomasterfrom
Conversation
Fixes a regression introduced by #54 - in the browser by default the response body is interpreted as a string which can become corrupted when non-printable characters are encountered.
vasco-santos
approved these changes
Aug 14, 2020
jacobheun
approved these changes
Aug 14, 2020
Member
Author
|
This is a band-aid, see #54 (comment) |
We should just close this and revert the change until we can do progress updates properly then |
|
We've decided not to do this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced by #54 - in the browser by default the response body is interpreted as a string which can become corrupted when non-printable characters are encountered.
Setting the responseType param to
arraybuffermakes it behave in a similar way to node.This is currently manifesting itself as a browser test failure for ipfs as the DAG node is retrieved from the server with garbage characters in the block: