Skip to content
This repository was archived by the owner on Mar 10, 2020. It is now read-only.

refactor: Use aegir#249

Merged
dignifiedquire merged 6 commits intomasterfrom
dignified
Apr 17, 2016
Merged

refactor: Use aegir#249
dignifiedquire merged 6 commits intomasterfrom
dignified

Conversation

@dignifiedquire
Copy link
Copy Markdown
Contributor

No description provided.

@dignifiedquire
Copy link
Copy Markdown
Contributor Author

Updated version of #233

@daviddias
Copy link
Copy Markdown
Contributor

Seems that there are some leftovers

/home/travis/build/ipfs/js-ipfs-api/node_modules/aegir/config/webpack.js:15
if (pkg.aegir && pkg.dignified.webpack) {
                              ^
TypeError: Cannot read property 'webpack' of undefined

@dignifiedquire
Copy link
Copy Markdown
Contributor Author

@diasdavid that's already fixed, the main issue is this: https://travis-ci.org/ipfs/js-ipfs-api/jobs/122904881 which I'm not sure how to solve

@daviddias daviddias changed the title refactor: Use dignified.js refactor: Use aegir Apr 15, 2016
@daviddias
Copy link
Copy Markdown
Contributor

We need to find a way to skip the log tests in PhantomJS, they are the only ones that break the process.

@dignifiedquire dignifiedquire mentioned this pull request Apr 15, 2016
36 tasks
@dignifiedquire
Copy link
Copy Markdown
Contributor Author

@diasdavid this should turn green any moment now, skipping log.tail on PhantomJS for now

@dignifiedquire dignifiedquire merged commit 6949e62 into master Apr 17, 2016
@dignifiedquire dignifiedquire deleted the dignified branch April 17, 2016 18:25
@daviddias
Copy link
Copy Markdown
Contributor

sweet! thank you :) Need to release then.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants