This repository was archived by the owner on Feb 12, 2024. It is now read-only.
Use cache to improve pin performance#2198
Closed
dirkmc wants to merge 6 commits intofix/offline-blockstorefrom
Closed
Use cache to improve pin performance#2198dirkmc wants to merge 6 commits intofix/offline-blockstorefrom
dirkmc wants to merge 6 commits intofix/offline-blockstorefrom
Conversation
Member
|
Hi! js-ipfs master just got a whole new set of automated tests with #2528, #2440 and also running some of the test suites from our early testers (hi5 to @achingbrain for setting it all up!). Would you mind rebasing the master branch on this PR to ensure it runs all the latest tests? Thank you! |
5 tasks
Member
|
Pinning is now handled by the ipfs-repo module, and pins are stored in the datastore not a DAG so this PR should be rewritten if we still want to do caching in this style. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2197
Note: This PR is branched off the Offline Blockstore PR, because the fix in the Offline Blockstore PR allows us to parallelize some pinning operations that would otherwise be prohibitively slow.