This repository was archived by the owner on Feb 12, 2024. It is now read-only.
fix: libp2p records for ipns should be signed#1543
Merged
Conversation
Member
|
UPDATE: I take that back the |
0da198c to
00b1cdf
Compare
Member
Author
|
@alanshaw edited the initial description of the PR. Does it make sense to you now? |
00b1cdf to
881a312
Compare
alanshaw
approved these changes
Sep 7, 2018
Member
alanshaw
left a comment
There was a problem hiding this comment.
LGTM. I have rebased for you and just waiting on CI again now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two types of IPNS records. IPNS records for being stored locally and IPNS records for being used in the network.
IPNS records for being stored locally are used for understanding which is the most recent record since it is stored by the peer who published it.
IPNS records for being used in the network, are used as a common libp2p-record and are intended to be used with the DHT and Pubsub.
This way, the
libp2p-recordshould have a signature and that signature should be validated on the resolve, in order to guarantee that the record was not changed in the network.NOTE: The current implementation guarantees that the
IPNS Recordis not changed, since it has its own signature, but thelibp2p-recordused must be used as a genericlibp2p-record, with its own signature as well.