Implementation bug in normaliseInput

I am pretty sure following lines would throw `TypeError: iterator is not iterable` because `yield *` expression expects iterable and not an iterator.  

https://github.com/ipfs/js-ipfs/blob/8cb8c73037e44894d756b70f344b3282463206f9/packages/ipfs-core-utils/src/files/normalise-input.js#L73-L82

https://github.com/ipfs/js-ipfs/blob/8cb8c73037e44894d756b70f344b3282463206f9/packages/ipfs-core-utils/src/files/normalise-input.js#L114-L122

https://github.com/ipfs/js-ipfs/blob/8cb8c73037e44894d756b70f344b3282463206f9/packages/ipfs-core-utils/src/files/normalise-input.js#L191-L199

It is also worrying that no tests seem to catch that.

	const iterator = input[Symbol.iterator]()
	const first = iterator.next()
	if (first.done) return iterator

	// Iterable<Number>
	// Iterable<Bytes>
	if (Number.isInteger(first.value) \|\| isBytes(first.value)) {
	yield toFileObject((function * () {
	yield first.value
	yield * iterator

	const iterator = input[Symbol.asyncIterator]()
	const first = await iterator.next()
	if (first.done) return iterator

	// AsyncIterable<Bytes>
	if (isBytes(first.value)) {
	yield toFileObject((async function * () { // eslint-disable-line require-await
	yield first.value
	yield * iterator

	const iterator = input[Symbol.iterator]()
	const first = iterator.next()
	if (first.done) return iterator

	// Iterable<Number>
	if (Number.isInteger(first.value)) {
	yield toBuffer(Array.from((function * () {
	yield first.value
	yield * iterator

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implementation bug in normaliseInput #3138

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Implementation bug in normaliseInput #3138

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions