Skip to content

feat: Add Filebase to List of Pinning Providers#2012

Merged
SgtPooki merged 1 commit intoipfs:mainfrom
filebase:main
Sep 12, 2022
Merged

feat: Add Filebase to List of Pinning Providers#2012
SgtPooki merged 1 commit intoipfs:mainfrom
filebase:main

Conversation

@jtsmedley
Copy link
Copy Markdown
Contributor

@jtsmedley jtsmedley commented Aug 22, 2022

  • Add Filebase to List of Pinning Providers

@jtsmedley
Add Filebase to List of Pinning Providers (#1)
112ca11 
* Add Filebase to List of Pinning Providers
@welcome
Copy link
Copy Markdown

welcome bot commented Aug 22, 2022

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines
    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@jtsmedley jtsmedley changed the title Add Filebase to List of Pinning Providers feat: Add Filebase to List of Pinning Providers Sep 2, 2022
@SgtPooki
Copy link
Copy Markdown
Member

SgtPooki commented Sep 12, 2022

Filebase is in the pinning-service-compliance checker now and showing 100%: https://ipfs-shipyard.github.io/pinning-service-compliance/api.filebase.io.html

SgtPooki
SgtPooki reviewed Sep 12, 2022
View reviewed changes
src/constants/pinning.js
Comment on lines +26 to +31
},
{
name: 'Filebase',
icon: 'https://dweb.link/ipfs/QmWBaeu6y1zEcKbsEqCuhuDHPL3W8pZouCPdafMCRCSUWk?filename=filebase.png',
apiEndpoint: 'https://api.filebase.io/v1/ipfs',
visitServiceUrl: 'https://docs.filebase.com/api-documentation/ipfs-pinning-service-api'
Copy link
Copy Markdown
Member

@SgtPooki SgtPooki Sep 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All values look good here and filebase is passing 100% on pinning service compliance checker. Will check the icon in webui before merging.

Copy link
Copy Markdown
Member

@SgtPooki SgtPooki Sep 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

looks good.

@SgtPooki SgtPooki self-requested a review September 12, 2022 17:01
@jtsmedley jtsmedley temporarily deployed to Deploy September 12, 2022 19:09 Inactive
@SgtPooki SgtPooki merged commit fe4ef00 into ipfs:main Sep 12, 2022
@SgtPooki SgtPooki mentioned this pull request Sep 13, 2022
Closed
5 tasks
@ipfs-gui-bot
Copy link
Copy Markdown
Collaborator

ipfs-gui-bot commented Sep 13, 2022

🎉 This PR is included in version 2.18.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@SgtPooki SgtPooki SgtPooki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jtsmedley @SgtPooki @ipfs-gui-bot