Conversation
|
Thanks, @rafaelramalho19, but can you please look at the "to do" item when you get a chance? Thank you! |
|
@jessicaschilling by help text you mean the |
|
@rafaelramalho19 - cliModal.ExtraNotes is customized as part of this work (that's the helptext), but I can't get it to display conditionally for the "Set pinning" command under the "three dots" context menu. |
|
Thanks, @rafaelramalho19! @lidel - can you please have a look when you get the chance? Would be one more item done in the pinning epic ... |
lidel
left a comment
There was a problem hiding this comment.
LGTM but we should make key names more explicit,
will save us time when debugging bugs in the future :)
@jessicaschilling mind updating places where below keys are used?
Co-authored-by: Marcin Rataj <lidel@lidel.org>
Co-authored-by: Marcin Rataj <lidel@lidel.org>
|
@lidel - good call. Updated. Please merge at your leisure ... |
Closes #1686.
This PR separates out the i18n key
cliModal.extraNotesso we can display different CLI Tutor Mode modal helptext in different situations:To do:
The i18n keys are split out, but I'm missing something that's probably obvious in terms of getting helptext to display when a tutor-mode modal is invoked from the context menu. @lidel or @rafaelramalho19, do you mind a quick look if you get the chance? 🙏