-
Notifications
You must be signed in to change notification settings - Fork 528
Improve Implicit service:cid Conversion #2042
Copy link
Copy link
Open
Labels
P2Medium: Good to have, but can wait until someone steps upMedium: Good to have, but can wait until someone steps upexp/intermediatePrior experience is likely helpfulPrior experience is likely helpfulkind/discussionTopical discussion; usually not changes to codebaseTopical discussion; usually not changes to codebasekind/enhancementA net-new feature or improvement to an existing featureA net-new feature or improvement to an existing featurestatus/readyReady to be workedReady to be workedtopic/design-contentContent design, writing, information architectureContent design, writing, information architecture
Description
Metadata
Metadata
Assignees
Labels
P2Medium: Good to have, but can wait until someone steps upMedium: Good to have, but can wait until someone steps upexp/intermediatePrior experience is likely helpfulPrior experience is likely helpfulkind/discussionTopical discussion; usually not changes to codebaseTopical discussion; usually not changes to codebasekind/enhancementA net-new feature or improvement to an existing featureA net-new feature or improvement to an existing featurestatus/readyReady to be workedReady to be workedtopic/design-contentContent design, writing, information architectureContent design, writing, information architecture
In multiple places of our code base, we convert pin information, stored as
service:cid, using.split(':'). This can open the way for some bugs (unlikely unless some data is corrupted or manually changed in the user's local storage). We can replace this instances by some method that validates the string and returns the expected output.ipfs-webui/src/bundles/pinning.js
Lines 13 to 15 in 183c476
ipfs-webui/src/files/files-list/FilesList.js
Line 26 in 83ceac1
And some others introduced in #1919.