Skip to content

Clean Kubo Client Story and Deprecated Packages#1731

Merged
hacdias merged 3 commits intomainfrom
kubo-rpc-client
Oct 10, 2023
Merged

Clean Kubo Client Story and Deprecated Packages#1731
hacdias merged 3 commits intomainfrom
kubo-rpc-client

Conversation

@hacdias
Copy link
Member

@hacdias hacdias commented Oct 9, 2023 •
edited
Loading

Describe your changes

  1. Remove the bunch of packages that have been deprecated since we migrated to Boxo
  2. Point users to kubo/client/rpc - see more context in Point users at canonical kubo/client/rpc library kubo#9124.

Files changed

  • docs/reference/go/api.md
  • docs/reference/kubo-rpc-cli.md

Checklist before requesting a review

  • Passing the beta version of the Check Markdown links for modified files check. Action results can be viewed here.
    • Well, the action is complaining about a lot of links that were already there and I did not touch them.

Checklist before merging

  • Passing all required checks (The beta Check Markdown links for modified files check is not required)

@hacdias hacdias requested review from 2color, ElPaisano and lidel October 9, 2023 08:55
hacdias
hacdias commented Oct 9, 2023
View reviewed changes
@hacdias hacdias marked this pull request as draft October 9, 2023 08:57
@hacdias hacdias marked this pull request as ready for review October 9, 2023 08:58
@hacdias hacdias self-assigned this Oct 9, 2023
@hacdias hacdias mentioned this pull request Oct 9, 2023
Closed
11 tasks
hacdias
hacdias commented Oct 9, 2023
View reviewed changes
docs/reference/go/api.md
Comment on lines -51 to -52
> This table is generated using the module [`package-table`](https://github.com/ipfs-shipyard/package-table) with `package-table --data=package-list.json`.

Copy link
Member Author

@hacdias hacdias Oct 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ I removed this because (1) this list is not generated by package-table anymore since 9459790 (package-table also does not have support for the Go Reference column), and (2) there's no package-list.json in this repository to generate it.

@hacdias hacdias mentioned this pull request Oct 9, 2023
Merged
ElPaisano
ElPaisano approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@ElPaisano ElPaisano left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

RE failing GH actions: We can ignore. Link check is flagging GH short link notation (i.e. link text like jeremy-ellis-tech/net-ipfs-http-client, ok) and spelling check is flagging part of a URL (codecov, ok).

@hacdias hacdias merged commit 6e971aa into main Oct 10, 2023
@hacdias hacdias deleted the kubo-rpc-client branch October 10, 2023 10:12
@BigLep BigLep mentioned this pull request Nov 9, 2023
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lidel lidel Awaiting requested review from lidel

@2color 2color Awaiting requested review from 2color

1 more reviewer

@ElPaisano ElPaisano ElPaisano approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hacdias hacdias

Labels

None yet

Projects

No open projects
IPFS Shipyard Team
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hacdias @ElPaisano