fix: refine errors for private maddr dial failures#98
Merged
Conversation
When connection gater blocks private addresses, provide clearer error messages instead of showing detailed "gater disallows connection to peer" errors. - Add formatConnectionError function to detect and summarize private address failures - Show "all X addresses are private/local" when only private addresses are found - Show "no good addresses (X private addresses filtered out)" when mixed - Preserve original error messages for other connection failures - Add tests for error formatting scenarios Fixes #96
SgtPooki
approved these changes
Jul 25, 2025
Member
SgtPooki
left a comment
There was a problem hiding this comment.
pretty straightforward change, lgtm.. a few comments
Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com>
gammazero
approved these changes
Jul 28, 2025
daemon.go
Outdated
| if privateCount > 0 { | ||
| if publicCount == 0 { | ||
| return fmt.Sprintf("failed to dial: all %d addresses are private/local and cannot be reached from the public internet", privateCount) | ||
| } else { |
Member
|
@2color mind merging & releasing & deploying to prod? 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When connection gater blocks private addresses, provide clearer error messages
instead of showing detailed "gater disallows connection to peer" errors.
Fixes #96
Related: ipshipyard/roadmaps#11