Skip to content
This repository was archived by the owner on Aug 1, 2023. It is now read-only.

fix: enable browser-browser-go circuit test#64

Merged
alanshaw merged 2 commits intomasterfrom
fix/browser-browser-go
Apr 16, 2019
Merged

fix: enable browser-browser-go circuit test#64
alanshaw merged 2 commits intomasterfrom
fix/browser-browser-go

Conversation

@jacobheun
Copy link
Copy Markdown
Contributor

This reenables the browser-browser-go circuit test which is working.

fixes #16

@ghost ghost assigned jacobheun Apr 16, 2019
@ghost ghost added the status/in-progress In progress label Apr 16, 2019
@jacobheun
Copy link
Copy Markdown
Contributor Author

The circuit tests are passing, but ipns still appears to be flakey. @vasco-santos any idea why?

@vasco-santos
Copy link
Copy Markdown
Member

wow, that is a new failure. Let me have a look

@vasco-santos
Copy link
Copy Markdown
Member

So go-ipfs now have a new property for publishing names offline: https://github.com/ipfs/go-ipfs/blob/master/core/commands/name/publish.go#L24

I just added a commit passing that and I will open an issue in js-ipfs for adding that property.

@vasco-santos
Copy link
Copy Markdown
Member

We got a cid test failure on windows. I restarted the job

@alanshaw alanshaw merged commit eaffbcf into master Apr 16, 2019
@alanshaw alanshaw deleted the fix/browser-browser-go branch April 16, 2019 15:00
@ghost ghost removed the status/in-progress In progress label Apr 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

circuit interop - browser-browser-go failing

3 participants