This repository was archived by the owner on Aug 1, 2023. It is now read-only.
fix: update tests to support go-ipfs automatic sharding#382
Closed
aschmahmann wants to merge 2 commits intomasterfrom
Closed
fix: update tests to support go-ipfs automatic sharding#382aschmahmann wants to merge 2 commits intomasterfrom
aschmahmann wants to merge 2 commits intomasterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
aschmahmann
commented
Oct 13, 2021
test/files.js
Outdated
Comment on lines
+12
to
+15
| const SHARD_THRESHOLD = 2000 | ||
| // Use this to help push the shard threshold over the go-ipfs defaults | ||
| // without just adding lots of files | ||
| const shardFilePadding = "".padStart(100, '0') |
Contributor
Author
There was a problem hiding this comment.
@achingbrain we could figure out adding a configurable sharding threshold in go-ipfs. However, this seemed like it wasn't super painful and wouldn't make tests take too much longer. WDYT?
Member
There was a problem hiding this comment.
Having a configurable sharding threshold makes things like the test added as part of ipfs/js-ipfs#3936 more feasible. One or two tests like this are not super painful, but twenty or thirty would be.
Member
There was a problem hiding this comment.
It also means you can do the whole test in code instead of having to deal with importing car files to get HAMTs that are *just so*. Doing it all in code means it's easy to run in environments without filesystems like browsers.
0b57851 to
69832a6
Compare
69832a6 to
35e4be4
Compare
aschmahmann
commented
Nov 17, 2021
Switch to version that includes ipfs/js-ipfs#3936
742c0ba to
f001775
Compare
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.