Skip to content
This repository was archived by the owner on Mar 10, 2020. It is now read-only.

fix: update dht tests#383

Closed
vasco-santos wants to merge 1 commit intomasterfrom
fix/dht-put-and-get
Closed

fix: update dht tests#383
vasco-santos wants to merge 1 commit intomasterfrom
fix/dht-put-and-get

Conversation

@vasco-santos
Copy link
Copy Markdown
Contributor

@vasco-santos vasco-santos commented Oct 29, 2018 •
edited by alanshaw
Loading

In this PR, a currently broken test is skipped and a new test was added to both dht.get and dht.put.

In the context of js-ipfs#856 and more precisely js-ipfs#856#issuecomment-435507070.

Needs:

@ghost ghost assigned vasco-santos Oct 29, 2018
@ghost ghost added the in progress label Oct 29, 2018
@vasco-santos vasco-santos mentioned this pull request Oct 29, 2018
Merged
35 tasks
@vasco-santos vasco-santos changed the title [WIP] fix: update dht tests fix: update dht tests Nov 3, 2018
daviddias
daviddias approved these changes Nov 3, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vasco-santos do you confirm that these pass with latest js-ipfs-api and latest js-ipfs?

@vasco-santos
Copy link
Copy Markdown
Contributor Author

vasco-santos commented Nov 3, 2018

js-ipfs-api is ok, but js-ipfs will need the ipfs/js-ipfs#856, which will need the next libp2p release first. Added a proper label here.

@vasco-santos vasco-santos force-pushed the fix/dht-put-and-get branch 3 times, most recently from 91e5259 to 60e089d Compare December 5, 2018 11:28
@victorb victorb removed their request for review April 26, 2019 13:11
alanshaw pushed a commit that referenced this pull request May 31, 2019
fix: dht tests
f5b569c 
closes #383

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
@alanshaw alanshaw mentioned this pull request May 31, 2019
Merged
alanshaw pushed a commit that referenced this pull request May 31, 2019
fix: dht tests (#486)
2952672 
closes #383

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
@daviddias daviddias deleted the fix/dht-put-and-get branch June 3, 2019 09:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@travisperson travisperson Awaiting requested review from travisperson

@alanshaw alanshaw Awaiting requested review from alanshaw

1 more reviewer

@daviddias daviddias daviddias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vasco-santos vasco-santos

Labels

blocked in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vasco-santos @daviddias @momack2 @hsanjuan