Merged
Conversation
Adds a `trace` option to all routing methods that can be used with libp2p metrics implementations that support method tracing.
2color
reviewed
Jan 13, 2025
| optionsIndex: 1 | ||
| }) ?? this.findProviders | ||
| this.provide = components.metrics?.traceFunction('helia.routing.provide', this.provide.bind(this), { | ||
| optionsIndex: 1 |
Member
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
Even after having read that, I'm not sure how optionsIndex influences the trace context and what the value should be, e.g. why do some of the calls here use optionsIndex: 2
Member
Author
There was a problem hiding this comment.
The metrics implementation has to know which argument is the options object in order to extract the trace context. It can't figure it out for itself so we have to tell it:
myTracedFunction(arg0, arg1, options) // <-- optionsIndex = 2
myOtherTracedFunction(arg0, options) // <-- optionsIndex = 1
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
traceoption to all routing methods that can be used with libp2p metrics implementations that support method tracing.Change checklist