Conversation
rvagg
commented
Mar 7, 2023
willscott
approved these changes
Mar 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you try to iterate over a shard where you don't have access to all the blocks, because we don't propagate the actual error we get an overrun error, which doesn't tell you much. This change propagates the error so you have a chance at intuiting what's going on.
If you
car extractthe wikipedia partial CAR in ipld/go-car#384 prior to this change you get an error:with this change you get:
the first CID is the shard root, the second CID is the first one in the substrate that it tries to load for a complete iteration.