update merkeldag to use the explicit decoder registry#104
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
rvagg
left a comment
There was a problem hiding this comment.
very nicely nonbreaking
👍 when the version is bumped and go mod is tidied
|
@aschmahmann should i wait to merge this to stay in sync with the variant you're working on in boxo? |
|
Up to you. Might be easier in case we find any other oddities along the way. Sorry I'm the slow leg here, plan is to get the next round of everything bubbled up today for people to test with tomorrow. However, if you don't want things to exactly match anymore that's ok too. e.g. if boxo adds a setter for the registry and you don't want to. |
|
ending up with 2 variants of this code with slightly different semantics so that it's harder to migrate seems worse than keeping them in sync |
|
@aschmahmann - this should now include #105 and matches what's in boxo |
Update the interface of
go-ipld-legacyto reflect the change in ipfs/go-ipld-legacy#12There is no breaking interface change in this update.
will wait until v0.2.0 of legacy is tagged and then use that version as the dependency here.
needs the equivalent update in the boxo fork of this repo i think.