adjust env vars, add regex based level setting#64
Merged
Conversation
Kubuxu
approved these changes
Sep 19, 2019
lanzafame
approved these changes
Sep 19, 2019
| loggerMutex.Lock() | ||
| defer loggerMutex.Unlock() | ||
| for name := range loggers { | ||
| if rem.MatchString(name) { |
Contributor
There was a problem hiding this comment.
Do we want to know if the regex fails to match any of the subsystems?
Member
Author
There was a problem hiding this comment.
Good question. I would be willing to log an Info message for this case, since an error seems incorrect here.
Member
Author
There was a problem hiding this comment.
on second thought the lack of match should be obvious by the logging output not changing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
62f287c contains api breaking changes, figured we might as well rip the rest of the bandages off.