Conversation
1. Use an interface instead of a map so that we can define fancier block decoders. 2. Make DefaultBlockDecoder thread safe.
Member
Author
|
@whyrusleeping I can also go ahead and implement an RCU now if you're concerned about speed. |
Member
|
Acquiring ReadLock if there are no contesting writes is only matter of incrementing one atomic |
Kubuxu
approved these changes
Jul 11, 2017
Member
Author
|
An atomic load should be an order of magnitude faster than an atomic add but that probably makes no difference in the grand scheme of things. |
whyrusleeping
approved these changes
Jul 11, 2017
Member
|
ship it 🚢 🐑 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
decoders.