This repository was archived by the owner on Mar 9, 2022. It is now read-only.
Add Init Alternative allowing specification of ED25519 key#78
Merged
Add Init Alternative allowing specification of ED25519 key#78
Conversation
Stebalien
reviewed
Apr 21, 2020
jacobheun
reviewed
Apr 28, 2020
jacobheun
left a comment
There was a problem hiding this comment.
Test coverage in this repo is pretty bad, perhaps we should add some tests here to validate we're getting the correct keys?
Updated approach LGTM
a7317cf to
4564a41
Compare
Contributor
Author
|
added a test 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to support generating other types of keys at initialization as tracked by ipfs/kubo#6916