Skip to content

refactor: move external command checks into commands lib#198

Merged
aschmahmann merged 2 commits intomasterfrom
feat/refactor-commands
Aug 4, 2020
Merged

refactor: move external command checks into commands lib#198
aschmahmann merged 2 commits intomasterfrom
feat/refactor-commands

Conversation

@aschmahmann
Copy link
Contributor

No description provided.

@welcome
Copy link

welcome bot commented Jul 30, 2020

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@aschmahmann aschmahmann requested a review from Stebalien July 30, 2020 18:47
@aschmahmann aschmahmann merged commit df39339 into master Aug 4, 2020
@aschmahmann aschmahmann mentioned this pull request Sep 22, 2020
72 tasks
@gammazero gammazero deleted the feat/refactor-commands branch July 10, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants