Skip to content

fix(key): dont allow backup key to be named 'self'#7615

Merged
aschmahmann merged 2 commits intomasterfrom
fix/keystore-rotate
Aug 24, 2020
Merged

fix(key): dont allow backup key to be named 'self'#7615
aschmahmann merged 2 commits intomasterfrom
fix/keystore-rotate

Conversation

@jacobheun
Copy link
Contributor

@jacobheun jacobheun commented Aug 21, 2020 •
edited
Loading

It's currently possible to backup your Identity with the self name when rotating keys, ipfs key rotate -o self. This results in a second self key in the keystore list. The name is now checked to avoid this.

I also updated the help text to be a bit clearer. It wasn't apparent that key rotation only applied to the Identity key.

@jacobheun
fix(key): dont allow backup key to be named 'self'
0ed43e9 
docs: update the key rotate help docs to be clearer about the backup
@welcome
Copy link

welcome bot commented Aug 21, 2020

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines
    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@jacobheun jacobheun requested a review from aschmahmann August 21, 2020 17:48
@aschmahmann aschmahmann merged commit 92fbcc3 into master Aug 24, 2020
@aschmahmann aschmahmann mentioned this pull request Sep 22, 2020
Closed
72 tasks
@hacdias hacdias deleted the fix/keystore-rotate branch May 9, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aschmahmann aschmahmann aschmahmann approved these changes

+1 more reviewer

@ShawkiS ShawkiS ShawkiS approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jacobheun @aschmahmann @ShawkiS