systemd: specify repo path, to avoid unnecessary subdirectory#7472
Merged
Stebalien merged 1 commit intoipfs:masterfrom Jun 16, 2020
Merged
systemd: specify repo path, to avoid unnecessary subdirectory#7472Stebalien merged 1 commit intoipfs:masterfrom
Stebalien merged 1 commit intoipfs:masterfrom
Conversation
Member
|
That's reasonable, but I'm pretty sure |
Contributor
Author
|
Well, I've tested it before I made the PR. I thought IPFS makes the expansion, but it works without. The environment variable gets expanded by the system: $ export IPFS_PATH=~
$ echo $IPFS_PATH
/home/ruben
$ /usr/bin/ipfs init
initializing IPFS node at /home/ruben
generating 2048-bit RSA keypair...done
peer identity: QmX35MVTjvJ3BxPABcphzsJJcPwUkKVL96icYP23mHgqWY
to get started, enter:
ipfs cat /ipfs/QmQPeNsJPyVWPFDVHb77w8G42Fvo15z4bG2X8D2GhfbSXc/readme
|
Member
|
Ah, you're right. go-ipfs does expand it (although I have no idea why). However, please use |
e5b884b to
b47ecd0
Compare
Contributor
Author
|
@Stebalien please rereview :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reational
Currently, the service files will create a hidden directory '/var/lib/ipfs/.ipfs/' which is not necessary for a system-user installation since it won't store any additional files - like in a regular user directory.
This change will set the directory to '/var/lib/ipfs/' to avoid this.