fix(commands): print consistent addresses in ipfs id#7397
Merged
Conversation
Consistently append `/p2p/QmMyId` to addresses when calling `ipfs id Me` and `ipfs id NotMe`. Fixes #7378.
a691024 to
3aa86f8
Compare
achingbrain
requested changes
Jun 2, 2020
Member
achingbrain
left a comment
There was a problem hiding this comment.
The tests only test that the output of ipfs id is the same for local and remote nodes, not that /p2p/ is prepended to the id in the output as the PR description says?
Member
Author
|
Well, the test is to fix the issue where |
achingbrain
approved these changes
Jun 2, 2020
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consistently append
/p2p/QmMyIdto addresses when callingipfs id Meandipfs id NotMe.Fixes #7378.