Merged
Conversation
We can add a proper configuration option in a followup patch after the RC.
| } | ||
|
|
||
| func Security(enabled bool) interface{} { | ||
| func Security(enabled bool, securityTransportOverride []string) interface{} { |
There was a problem hiding this comment.
@Stebalien Why have we added the securityTransportOverride option ? Is there any use case for it right now ?
Member
Author
There was a problem hiding this comment.
At the moment, go-ipfs prefers TLS, then SECIO, then Noise. That means the noise transport will never be used by default. The override option lets us actually use noise by:
- Putting it before TLS.
- Removing SECIO.
- Etc...
See the tests and the new experimental-features documentation for details. If it doesn't make sense, I'll expand the documentation in a followup PR.
Member
Author
There was a problem hiding this comment.
(also provides a way to disable noise if it causes problems)
aarshkshah1992
approved these changes
May 26, 2020
aarshkshah1992
left a comment
There was a problem hiding this comment.
Just one comment to understand when we would want to override security transports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can add a proper configuration option in a followup patch after the RC.