misc config/experimental-features doc fixes#7333
Merged
Conversation
aschmahmann
approved these changes
May 20, 2020
Contributor
There was a problem hiding this comment.
Overall seems reasonable to me. Two things I might add, but that we could do in another PR are:
- Update the IPNS over PubSub experimental text
- Reading through the diff in the GitHub UI is awful because some of our JSON isn't properly formatted (e.g. a
}is missing from https://github.com/ipfs/go-ipfs/blob/doc/misc-fixes/docs/config.md#gatewaypathprefixes). We may want to clean these up.
lmk if you want me to do either of these changes or review them if you do them. Otherwise, LGTM
Member
Author
|
@aschmahmann feel free to make those changes (and any other doc cleanups, we have many...) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.