fix(mkreleasenotes): include commits directly to master#7296
Merged
fix(mkreleasenotes): include commits directly to master#7296
Conversation
We should be including multiformats repos and repos from our core contributors.
This will include: * Commits to master. * Squashed merges. In the release notes.
ribasushi
approved these changes
May 9, 2020
Contributor
ribasushi
left a comment
There was a problem hiding this comment.
Looks great!
Suggested small addition that made it run for me locally
| @@ -6,8 +6,30 @@ export GOPATH="$(go env GOPATH)" | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Not everybody has go-ipfs pulled down as an actual dep
Suggested change
| ! [[ -d "$GOPATH/src/github.com/ipfs/go-ipfs" ]] \ | |
| && echo 'You must leave the current repository dir and `go get -v github.com/ipfs/go-ipfs` before using this script' \ | |
| && exit 1 |
Member
Author
There was a problem hiding this comment.
Well, this script assumes you're using a GOPATH and won't work without it, unfortunately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will include:
In the release notes.