Fixes #7252 - Uses gabriel-vasile/mimetype to support additional content types#7262
Merged
Stebalien merged 5 commits intoipfs:masterfrom May 4, 2020
gowthamgts:fix/http/content-type
Merged
Fixes #7252 - Uses gabriel-vasile/mimetype to support additional content types#7262Stebalien merged 5 commits intoipfs:masterfrom gowthamgts:fix/http/content-type
Stebalien merged 5 commits intoipfs:masterfrom
gowthamgts:fix/http/content-type
Conversation
This comment has been minimized.
This comment has been minimized.
hsanjuan
requested changes
May 1, 2020
hsanjuan
approved these changes
May 1, 2020
Stebalien
requested changes
May 2, 2020
Member
Stebalien
left a comment
There was a problem hiding this comment.
Otherwise LGTM. I've been fuzzing this library for a while and haven't found any crashes so this seems good to go.
Stebalien
approved these changes
May 4, 2020
Member
|
Hm. Apparently I didn't push my rebase to the right origin... |
Member
|
@gowthamgts thanks for the fix! |
hacdias
pushed a commit
to ipfs/boxo
that referenced
this pull request
Jan 27, 2023
Fixes #7252 - Uses gabriel-vasile/mimetype to support additional content types This commit was moved from ipfs/kubo@01e27f9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #7252 by replacing
http.DetectContentType()withmimetype.Detect()from https://github.com/gabriel-vasile/mimetype library.I've tested locally with the ODS files, mp3 files and html files. Please let me know if there's anything further that needs to be done!