Conversation
Stebalien
approved these changes
Apr 29, 2020
|
Today while working on HTTPError and TimeoutError while publishing and IPNS name I realized that even I'm behind a nat/firewall the errors vanished when I deactivated my DNSCrypt (Debian Buster). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #7244
Sometimes IPNS publishes can take longer than a minute. Since DHT lookups now terminate without needing to query a huge portion of the network (even if the lookups take a while until more of the network upgrades to v0.5.0+), we should allow the user's IPNS queries to go on until they're ready to cancel them.
Note: There's still a 30 second timeout on doing a record Get before Publishing, however this doesn't bother me too much since it both doesn't cause an error to be returned and the whole code path is a bit strange in general since it seems to only get called if either: