Conversation
4eaa27f to
dc16812
Compare
willscott
reviewed
Apr 27, 2020
dc16812 to
e07e17e
Compare
Contributor
|
It seems fine to have this as a DHT sub-command. I think the only question is if it's worth having a warning or otherwise making it clear that the format and underlying implementation-specific info that's showing up may change and this isn't a structure we're signing up to support long term. |
0c7bafa to
cdf6f21
Compare
Member
Author
|
willscott
approved these changes
May 15, 2020
core/commands/stat_dht.go
Outdated
| // parts. That is, change "2m3.00010101s" to "2m3s ago". | ||
| now := time.Now() | ||
| since := func(t time.Time) string { | ||
| return string(decimalRegex.ReplaceAll( |
Contributor
There was a problem hiding this comment.
locally, if i do
now.Sub(t).Round(time.Second).String() i don't see a decimal. When is this regex needed?
Member
Author
There was a problem hiding this comment.
You're right... that's a lot simpler.
7cffaed to
578d8b8
Compare
Currently, it just prints out the routing tables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, it just prints out the routing tables.
TODO
TestsIt's a debugging command.