Add module files for go-ipfs-as-a-library example#7146
Merged
Stebalien merged 2 commits intoipfs:masterfrom Apr 29, 2020
Merged
Add module files for go-ipfs-as-a-library example#7146Stebalien merged 2 commits intoipfs:masterfrom
Stebalien merged 2 commits intoipfs:masterfrom
Conversation
Contributor
|
Should we just document how to setup the example on a separate location? My main issue with this is that we might forget to keep this go.mod up to date, therefore the example might break when people want to use it with newer go-ipfs versions. |
Member
|
Eh, I'd add it. It's a good starting point. However, we should probably wait till the release so we can make it depend on v0.5.0 instead of a specific git commit. |
Contributor
|
I put it in the milestone so that we don't forget... |
Member
|
@lthibault could you rebase this and update go-ipfs to 0.5.0? |
Contributor
Author
|
@Stebalien Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6811.