This repository was archived by the owner on Mar 18, 2025. It is now read-only.
mod: update to the latest badger/v2 release#45
Merged
Conversation
Back in October 2020, we merged #31 to update to a commit from master, in order to pull in a fix for protobuf warnings/panics. Luckily, the upstream fix has now been backported and released as v2.2007.3. Use it, instead of continuing to rely on a stray master commit.
aschmahmann
approved these changes
Jul 22, 2021
Contributor
aschmahmann
left a comment
There was a problem hiding this comment.
LGTM, but I actually don't interact with Badger v2 almost at all since it's not bundled with go-ipfs. @Kubuxu any objections?
Contributor
Author
|
Even if we feel uneasy about merging this when this is unused/untested, I still think it's best to merge it, because right now master uses a fairly old master commit from badger :) |
gammazero
approved these changes
Jul 22, 2021
Collaborator
gammazero
left a comment
There was a problem hiding this comment.
Yes, finally. But are we ever going to use this in IPFS.
Kubuxu
approved these changes
Jul 22, 2021
Member
Kubuxu
left a comment
There was a problem hiding this comment.
In lotus we were using this version of badger either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(see commit message)