Conversation
Instead of giving up when a single datastore fails, operate on all datastores first. That way: * If one datastore doesn't support disk usage, we can at least return our best estimate for the ones that do. * If one datastore fails to sync, we won't fail to sync the others. * If one datastore refuses to close, we'll close the others. Etc. Also: * Drop xerrors. We already need go 1.13 elsewhere. * Use uber's multierr. It's much simpler than hashicorps (and is already a dependency through zap, fx, etc.).
1907e51 to
ae47316
Compare
27 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of giving up when a single datastore fails, operate on all datastores first. That way:
Etc.
Also: