Merged
Conversation
We call this frequently and having to allocate here is really unfortunate.
willscott
approved these changes
Jul 23, 2020
| offset += n | ||
| mhlen, _, _ := uvarint(c.str[offset:]) | ||
|
|
||
| return Prefix{ |
There was a problem hiding this comment.
could allocate this struct before the uvarint's above, and then read version / type / codec directly into the member fields
Member
There was a problem hiding this comment.
eh, it won't save us anything. Its all in registers at the end of the day
whyrusleeping
approved these changes
Jul 23, 2020
Kubuxu
approved these changes
Jul 23, 2020
Member
|
@Stebalien are we sure that varint in the |
Member
|
Ahh, doc is bad. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We call this frequently and having to allocate here is really unfortunate.